Use ReadExactly instead of Read where we expect to read a specific number of bytes

Browser virtual file systems might not always read the specified number of bytes when regular Read is called

Co-authored-by: Nayiem Willems <nayiemwillems@gmail.com>

Author: Rampastring

src/TSMapEditor/CCEngine/CCCrypto.cs

@@ -309,15 +309,12 @@ public override int Read(byte[] buffer, int offset, int count)
         }
 
         // Read new encrypted data to staging buffer.
-        int read = stream.Read(stagingBuffer, stagingBufferOffset, sizeToRead);
-
-        if ((read & (SIZE_OF_BLOCK - 1)) != 0)
-            throw new System.ArgumentException("Number of bytes read from encapsulated stream isn't a multiple of Blowfish block size");
+        stream.ReadExactly(stagingBuffer, stagingBufferOffset, sizeToRead);
 
         int dataStart = stagingBufferOffset - stagingRemainingBytes;
 
         // Decrypt blocks in-place in staging buffer.
-        for (int i = 0; i < read; i += SIZE_OF_BLOCK)
+        for (int i = 0; i < sizeToRead; i += SIZE_OF_BLOCK)
         {
             DecryptBlock();
             stagingBufferOffset += SIZE_OF_BLOCK;

src/TSMapEditor/CCEngine/MixFile.cs

@@ -87,19 +87,19 @@ public void Parse(Stream stream = null)
             entries = new List<MixFileEntry>();
 
             byte[] buffer = new byte[256];
-            stream.Read(buffer, 0, 4);
+            stream.ReadExactly(buffer, 0, 4);
             MixType mixType = (MixType)BitConverter.ToInt32(buffer, 0);
 
             bool isEncrypted = (mixType & MixType.ENCRYPTED) != 0;
 
             if (isEncrypted)
             {
                 // Read and decrypt the Blowfish associated with this MIX.
-                stream.Read(buffer, 0, KeyDecryptor.SIZE_OF_ENCRYPTED_KEY);
+                stream.ReadExactly(buffer, 0, KeyDecryptor.SIZE_OF_ENCRYPTED_KEY);
                 stream = new BlowfishStream(stream, KeyDecryptor.DecryptBlowfishKey(buffer));
             }
 
-            stream.Read(buffer, 0, MixFileHeader.SIZE_OF_HEADER);
+            stream.ReadExactly(buffer, 0, MixFileHeader.SIZE_OF_HEADER);
 
             MixFileHeader header = new MixFileHeader(buffer);
 
@@ -117,7 +117,7 @@ public void Parse(Stream stream = null)
                 if (stream.Position + MixFileEntry.SIZE_OF_FILE_ENTRY >= stream.Length)
                     throw new MixParseException("Invalid MIX file.");
 
-                stream.Read(buffer, 0, MixFileEntry.SIZE_OF_FILE_ENTRY);
+                stream.ReadExactly(buffer, 0, MixFileEntry.SIZE_OF_FILE_ENTRY);
                 entries.Add(new MixFileEntry(buffer));
             }
 
@@ -173,7 +173,7 @@ public byte[] GetFileData(int offset, int count)
             byte[] buffer = new byte[count];
 
             stream.Position = mixStartOffset + bodyOffset + offset;
-            stream.Read(buffer, 0, count);
+            stream.ReadExactly(buffer, 0, count);
 
             return buffer;
         }