enable quadratic for win with scip (PyPSA#588)

* enable quadratic for win with scip

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add release note

* Drop reference to SCIP bug

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Fabian Hofmann <fab.hof@gmx.de>

Author: 3 people

doc/release_notes.rst

@@ -9,6 +9,7 @@ Upcoming Version
 * Add ``linopy.breakpoints()`` factory for convenient breakpoint construction from lists, dicts, or keyword arguments. Includes ``breakpoints.segments()`` for disjunctive formulations.
 * Add the `sphinx-copybutton` to the documentation
 * Add SOS1 and SOS2 reformulations for solvers not supporting them.
+* Enable quadratic problems with SCIP on windows.
 
 
 Version 0.6.5

linopy/solver_capabilities.py

@@ -7,7 +7,6 @@
 
 from __future__ import annotations
 
-import platform
 from dataclasses import dataclass
 from enum import Enum, auto
 from importlib.metadata import PackageNotFoundError
@@ -181,21 +180,12 @@ def supports(self, feature: SolverFeature) -> bool:
         display_name="SCIP",
         features=frozenset(
             {
-                SolverFeature.INTEGER_VARIABLES,
-                SolverFeature.LP_FILE_NAMES,
-                SolverFeature.READ_MODEL_FROM_FILE,
-                SolverFeature.SOLUTION_FILE_NOT_NEEDED,
-            }
-            if platform.system() == "Windows"
-            else {
                 SolverFeature.INTEGER_VARIABLES,
                 SolverFeature.QUADRATIC_OBJECTIVE,
                 SolverFeature.LP_FILE_NAMES,
                 SolverFeature.READ_MODEL_FROM_FILE,
                 SolverFeature.SOLUTION_FILE_NOT_NEEDED,
             }
-            # SCIP has a bug with quadratic models on Windows, see:
-            # https://github.com/PyPSA/linopy/actions/runs/7615240686/job/20739454099?pr=78
         ),
     ),
     "mosek": SolverInfo(

test/test_optimization.py

@@ -55,7 +55,7 @@
     params.append(("mosek", "lp", True))
 
 
-# Note: Platform-specific solver bugs (e.g., SCIP quadratic on Windows) are now
+# Note: Platform-specific solver bugs are now
 # handled in linopy/solver_capabilities.py by adjusting the registry at import time.
 feasible_quadratic_solvers: list[str] = list(quadratic_solvers)