test(chrome-extension): verify WebRTC session description formatting - #2171
Open
gcoinstash-cmd wants to merge 10 commits into
Open
test(chrome-extension): verify WebRTC session description formatting#2171gcoinstash-cmd wants to merge 10 commits into
gcoinstash-cmd wants to merge 10 commits into
Conversation
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
Comment on lines
+83
to
+85
| expect(() => toSessionDescriptionInit(null)).toThrow( | ||
| "Missing session description", | ||
| ); |
Contributor
There was a problem hiding this comment.
Undefined case remains untested
This test claims to cover both null and undefined descriptions but invokes toSessionDescriptionInit only with null, so an undefined-input regression would leave the suite green despite the advertised coverage.
Suggested change
| expect(() => toSessionDescriptionInit(null)).toThrow( | |
| "Missing session description", | |
| ); | |
| expect(() => toSessionDescriptionInit(null)).toThrow( | |
| "Missing session description", | |
| ); | |
| expect(() => toSessionDescriptionInit(undefined)).toThrow( | |
| "Missing session description", | |
| ); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 83-85
Comment:
**Undefined case remains untested**
This test claims to cover both null and undefined descriptions but invokes `toSessionDescriptionInit` only with null, so an undefined-input regression would leave the suite green despite the advertised coverage.
```suggestion
expect(() => toSessionDescriptionInit(null)).toThrow(
"Missing session description",
);
expect(() => toSessionDescriptionInit(undefined)).toThrow(
"Missing session description",
);
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Greptile Summary
This PR expands unit coverage for WebRTC session-description conversion and several shared recorder utility behaviors.
Confidence Score: 4/5
The PR appears safe to merge, with only a non-blocking gap in the advertised undefined-input coverage.
The changes affect tests only, and the sole accepted concern is that one test names two nullish inputs while asserting only the null case.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(chrome-extension): verify WebRTC se..." | Re-trigger Greptile