Skip to content

test(chrome-extension): verify WebRTC session description formatting - #2166

Open
gcoinstash-cmd wants to merge 6 commits into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-desc-1788059674
Open

test(chrome-extension): verify WebRTC session description formatting#2166
gcoinstash-cmd wants to merge 6 commits into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-desc-1788059674

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Adds unit test coverage for WebRTC session description exchange in Chrome extension recording pipeline.
  • Test suite passed 100% green.

Greptile Summary

This PR adds unit coverage for WebRTC session-description conversion and several shared recorder utilities.

  • Verifies offer and answer serialization plus missing-description handling in the Chrome extension.
  • Covers recording-mode label heuristics, cancellation classification, and retryable display-capture errors in recorder core.

Confidence Score: 5/5

The PR appears safe to merge because it only adds passing unit coverage and introduces no actionable production or test-suite regression.

The new tests exercise existing WebRTC conversion, recording-mode detection, and error-classification behavior without modifying runtime code or establishing a misleading assertion that affects current supported inputs.

Important Files Changed

Filename Overview
apps/chrome-extension/src/shared/webrtc.test.ts Adds focused tests for converting offer and answer descriptions and rejecting a missing description; no actionable defect found.
packages/recorder-core/tests/recorder-utils.test.ts Adds coverage for recording-mode detection and capture-error classifiers without changing production behavior; no actionable defect found.

Reviews (1): Last reviewed commit: "test(chrome-extension): verify WebRTC se..." | Re-trigger Greptile

@superagent-security

Copy link
Copy Markdown

Manage your Superagent protection

Superagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans.

You have 0 of 3 included PR scans remaining.

Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant