From 02008925845247e4250d0f23b347164b027be1bd Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 7 Aug 2026 19:03:56 +0800 Subject: [PATCH 1/3] Consolidate ledger updates --- docs/branch-review-ledger.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/branch-review-ledger.md b/docs/branch-review-ledger.md index 676e40e033..170184d415 100644 --- a/docs/branch-review-ledger.md +++ b/docs/branch-review-ledger.md @@ -623,3 +623,4 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie | 2026-08-04 | claude/top-search-design-mockups-w53znc | b432448e4893a42d07558aff0dc04be797971231 | PR #1611 — results-band shelf Clear filter-only, memo deps, restored tests | Fixed two Qodo findings from merged #1555; mutation-tested guard added | tsc 0; eslint 0; vitest 4 files/59 tests; verify:pr-local blocked by lock parity (node 24.13 vs jsdom@30) | | 2026-08-04 | claude/search-bar-decisions-doc | a7dea7f777255ade72878820a636413aaf9588af | search-bar handoff doc replacement + review fixes | Docs-only review fixes: mode/shelf accounting, Sort consumers, #230/#170 precision; removed unquoted-output claim from prior row | prettier --check . ; check:outstanding-issues ; docs:check-links ; docs:check-index | | 2026-08-04 | claude/search-bar-decisions-doc | 3b4cd6e6bf1f36fb8aff098ce7d333641e0859d3 | search-bar handoff doc replacement + review fixes | Fixed CodeRabbit/Codex findings; Bugbot hosted stuck queued, local Bugbot-equivalent confirmed two P2 doc errors and rejected sheets-are-target finding. verify:pr-local PASS (docs scope). Decisive: prettier All matched files use Prettier code style!; outstanding-issues 228 rows next-id=231; docs link check passed: 1615; docs/codebase-index coverage OK | verify:pr-local (docs); prettier --check; check:outstanding-issues; docs:check-links; docs:check-index; check:branch-review-ledger | +| 2026-08-05 | HEAD | 2a8881afad230880166de60a533e17588d9920ec | seven-report repo-wide audit | P2 confirmed: live drift and live-only migration; mobile CLS; ACL runner; OOXML declared-size robustness; assertion false positives. Numerous report claims stale, narrowed, or unsafe. | verify:cheap (5088 pass, 3 skip, 1 timeout); focused retry 21/21 pass; build pass; bundle budget pass; offline RAG 574/574; assertions 98%; live drift 34; browser CLS 0.228/0.218 | From 413e679bb92cb19717d6d8301764df44694eb73e Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 7 Aug 2026 12:16:28 +0000 Subject: [PATCH 2/3] fix(ledger): keep main row order when consolidating PR #1683 Prefer origin/main's shared ledger queue and append only the missing seven-report audit row after the merge relocation. Co-authored-by: BigSimmo --- docs/branch-review-ledger.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/branch-review-ledger.md b/docs/branch-review-ledger.md index 474924b6df..6af7a9c742 100644 --- a/docs/branch-review-ledger.md +++ b/docs/branch-review-ledger.md @@ -588,6 +588,13 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie | 2026-08-02 | claude/ds-v2-values | d33721b436c05014e8ef1f362a945fe9574e676e | DS V2 PR-V values | Wave 2 self-verified before push: 5a close-out (no value deltas remain after decision J2; contract metrics unchanged at rawColorLiterals 2 / literalShadowClasses 0 / legacyTapClasses 0), 5b tap knob 2.75rem to 3rem in @theme with --tap-min reduced to var(--spacing-tap) across 426 *-tap sites and three pins flipped in-commit, 5c --radius-md 8px to 10px across 243 rounded-md sites with the 4px-grid pin naming both half-steps and 14 arbitrary radius literals absorbed. Two carve-outs recorded in SPEC 4.10/4.6: the phone composer stays 44px below 431px, and the 2px mode-nav hairline stays off the ladder. An offline.html tap bump was reverted before push because it would have forced a service-worker CACHE_VERSION bump. Known-red local gate: tests/ui-smoke.spec.ts:2221 phone runway pin fails on unmodified origin/main here too (maxOffset 99 at base vs 111 at this head, reproduced in a pristine capture worktree) while CI run 30720360137 is green on the same tree - plan finding L, CI binding. | typecheck exit 0; verify:pr-local PASS with 4880 passed 3 skipped (4883) in 471 files, production build compiled, client-bundle secret scan passed, eval:rag:offline fixture line plus 574/574 (better than the J4 known-red baseline); verify:ui 346 passed 1 failed (the known-red phone runway pin); verify:phone-chrome --full=never contracts 116/116 and ui-tools 87/87 with the same single known-red test; test:e2e:critical 15/15; design-system contract, branch-review-ledger, outstanding-issues, sitemap, docs link/index/inventory/scripts all exit 0 | | 2026-08-02 | claude/ds-v2-values | 48012d359b84daae347201697c82f3e433c182c5 | PR #1571 review-and-fix (ds-v2-values tap/radius) | fixed: Tools submit + account-setup close onto h-tap; phone composer input 44px pin; gate 2 demoted to implemented-partial; SPEC 407→426; short-runway/short-answer smoke pins retuned; verify:cheap + verify:pr-local + 2 smoke tests green; CI Production UI in progress | verify:cheap 471/4879; verify:pr-local build+fixtures; test:e2e 2 phone smoke passed; design-system-contract raw 2/0/0 | | 2026-08-02 | claude/ds-v2-values | d2a29198415292a28ed1dbf1c740c94f6c12ddb3 | PR #1571 review-and-fix (ds-v2-values tap/radius) | fixed+clarified: gate2 objective acknowledges h-10/unwired audit not blocked; overlay 430px assertion scoped to media block; prior tip 48012d35 Production UI+PR required green | verify:cheap; verify:pr-local; 2 smoke; UI overlay contract; CI Production UI (1)(2)(3)+PR required SUCCESS on 48012d35 | +| 2026-08-02 | codex/docker-delivery-hardening | ccdc8ff801056c7318cd0ecc99b461861f83cff4 | Figma MCP OAuth npm registry and Codex Cloud access | No P0/P1. Fixed P2 Cloud Figma credential scrub gap and removed unavailable duplicate desktop MCP; private registry auth and fresh Cloud acceptance remain external. | codex-cloud test 15/15; static Cloud PASS; targeted Prettier PASS; diff check PASS; Figma MCP read/write PASS; registry ping E401 | +| 2026-08-04 | origin/main | f57203bed761f0b782aeffe92883f7b608a80f94 | Codex Cloud environment readiness | P2 incomplete provider-variable scrub; live parity and provider acceptance unverified | local static inspection only; no provider or runtime calls | +| 2026-08-04 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | repo audit P0/P1/P2 | found 2 P1 and 4 P2 defects | typecheck, docs:check-scripts, docs:check-index, check:worker-python-lock, owner-scope, pr-policy, ledger-check | +| 2026-08-04 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | repo audit P0/P1/P2 (supersedes 2026-08-04) | found 3 P1 and 4 P2 defects | typecheck, vitest (1 failed: token contract), docs:check-scripts, docs:check-index, check:worker-python-lock, owner-scope, pr-policy, ledger-check | +| 2026-08-04 | origin/main | ea9d7f642b26aff1bbda0effb86e2c72754ff974 | design-system adoption audit | P1/P2: v2 shell unmounted; stale adoption docs; phone runway and component/accessibility residuals | exact-ref static audit; ancestor design contracts 83/83; no browser or providers | +| 2026-08-06 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | branch | clean | diff review | +| 2026-08-06 | codex/docker-delivery-hardening | 9f9e34ccffe3fe7c4bf5798b4d9697181a77180d | Docker pipeline hardening, worker graceful shutdown, Python lockfile, CI SBOMs | REVIEWED, findings fixed | format, docs:update, unit (test lock active) | | 2026-08-02 | codex/fix-manual-workflow-service-role-key-exposure / PR #1572 | 6cc0b6ffdae3b515a05a17f2a87e5f51e5347263 | PR review + fix (ingestion-autopilot service-role exposure) | Reviewed secret-hardening: workflow/job-level SUPABASE_SERVICE_ROLE_KEY removed, manual dispatch limited to default branch, checkout pinned to default_branch, secret scoped to Preflight + Run autopilot only. Fixed CI blockers: merged origin/main (branch was ~1144 behind; Gitleaks needed run-gitleaks-pinned.mjs), registered tests/ingestion-autopilot-workflow.test.ts in test:ci-workflows, Prettier + stronger step-only secret assertions. No P0/P1 residual in the hardened workflow; residual risk is intentional inability to dry-run workflow_dispatch from non-default branches until merge. | npm run test:ci-workflows 206/206; focused ci-cache-safety + ingestion-autopilot-workflow 21/21; check:github-actions; prettier --check; git diff --check. No OpenAI/Supabase/provider calls. | | 2026-08-02 | claude/ds-v2-answer-safety | 8ad91e3f0104b89b83a54255687408cae574ee88 | DS V2 PR-E slices 6+7+8: answer safety, form foundation, announcements | Clinical governance review: no P0; 8 findings fixed in-branch; P1-1 strengthened; #208/#209/#210 deferred and recorded. Zero product imports - nothing adopted. | verify:pr-local exit 0 (475 files / 4960 passed, offline RAG 23 suites / 574 passed); verify:ui 342 passed / 5 failed not attributable (no product import); e2e:critical 15 passed | | 2026-08-02 | claude/ds-v2-architecture | 157373700281f81f136275c56c9a82fb22776d99 | PR-Arch Wave4 motion/z/overlays/print | local gates green; frontend-ui-reviewer API-limited — glance required before auto-merge | unit 4972p; e2e:critical 15p; verify:ui 347p; verify:pr-local 0; eval:rag:offline pass | @@ -623,14 +630,6 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie | 2026-08-04 | claude/top-search-design-mockups-w53znc | b432448e4893a42d07558aff0dc04be797971231 | PR #1611 — results-band shelf Clear filter-only, memo deps, restored tests | Fixed two Qodo findings from merged #1555; mutation-tested guard added | tsc 0; eslint 0; vitest 4 files/59 tests; verify:pr-local blocked by lock parity (node 24.13 vs jsdom@30) | | 2026-08-04 | claude/search-bar-decisions-doc | a7dea7f777255ade72878820a636413aaf9588af | search-bar handoff doc replacement + review fixes | Docs-only review fixes: mode/shelf accounting, Sort consumers, #230/#170 precision; removed unquoted-output claim from prior row | prettier --check . ; check:outstanding-issues ; docs:check-links ; docs:check-index | | 2026-08-04 | claude/search-bar-decisions-doc | 3b4cd6e6bf1f36fb8aff098ce7d333641e0859d3 | search-bar handoff doc replacement + review fixes | Fixed CodeRabbit/Codex findings; Bugbot hosted stuck queued, local Bugbot-equivalent confirmed two P2 doc errors and rejected sheets-are-target finding. verify:pr-local PASS (docs scope). Decisive: prettier All matched files use Prettier code style!; outstanding-issues 228 rows next-id=231; docs link check passed: 1615; docs/codebase-index coverage OK | verify:pr-local (docs); prettier --check; check:outstanding-issues; docs:check-links; docs:check-index; check:branch-review-ledger | -| 2026-08-05 | HEAD | 2a8881afad230880166de60a533e17588d9920ec | seven-report repo-wide audit | P2 confirmed: live drift and live-only migration; mobile CLS; ACL runner; OOXML declared-size robustness; assertion false positives. Numerous report claims stale, narrowed, or unsafe. | verify:cheap (5088 pass, 3 skip, 1 timeout); focused retry 21/21 pass; build pass; bundle budget pass; offline RAG 574/574; assertions 98%; live drift 34; browser CLS 0.228/0.218 | -| 2026-08-02 | codex/docker-delivery-hardening | ccdc8ff801056c7318cd0ecc99b461861f83cff4 | Figma MCP OAuth npm registry and Codex Cloud access | No P0/P1. Fixed P2 Cloud Figma credential scrub gap and removed unavailable duplicate desktop MCP; private registry auth and fresh Cloud acceptance remain external. | codex-cloud test 15/15; static Cloud PASS; targeted Prettier PASS; diff check PASS; Figma MCP read/write PASS; registry ping E401 | -| 2026-08-04 | origin/main | f57203bed761f0b782aeffe92883f7b608a80f94 | Codex Cloud environment readiness | P2 incomplete provider-variable scrub; live parity and provider acceptance unverified | local static inspection only; no provider or runtime calls | -| 2026-08-04 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | repo audit P0/P1/P2 | found 2 P1 and 4 P2 defects | typecheck, docs:check-scripts, docs:check-index, check:worker-python-lock, owner-scope, pr-policy, ledger-check | -| 2026-08-04 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | repo audit P0/P1/P2 (supersedes 2026-08-04) | found 3 P1 and 4 P2 defects | typecheck, vitest (1 failed: token contract), docs:check-scripts, docs:check-index, check:worker-python-lock, owner-scope, pr-policy, ledger-check | -| 2026-08-04 | origin/main | ea9d7f642b26aff1bbda0effb86e2c72754ff974 | design-system adoption audit | P1/P2: v2 shell unmounted; stale adoption docs; phone runway and component/accessibility residuals | exact-ref static audit; ancestor design contracts 83/83; no browser or providers | -| 2026-08-06 | codex/docker-delivery-hardening | f1c8b582544ec57c64c98fced8a26ae29b94a43a | branch | clean | diff review | -| 2026-08-06 | codex/docker-delivery-hardening | 9f9e34ccffe3fe7c4bf5798b4d9697181a77180d | Docker pipeline hardening, worker graceful shutdown, Python lockfile, CI SBOMs | REVIEWED, findings fixed | format, docs:update, unit (test lock active) | | 2026-08-05 | claude/top-search-design-mockups-fbbfuf | 7eb723b097afadae010b57d66f4a4313b6d952a7 | results-bar redesign: shared band anatomy, applied-filter shelf, documents filter sheet, filtered-to-zero empty state | Implemented + self-reviewed; all twelve review findings resolved. Deviations from the mockup taken deliberately: fault state keeps three non-chromatic channels (mockup used colour alone, contradicting a recorded decision); 48px tap floor not the mockup's 44px (min-h-11 flake); one-line layout opt-in per mode because six pass a w-full select. Two pinned tests re-pointed, never deleted. | vitest 488 files/5107 passed; verify:ui run 1 348 passed 1 failed (ui-smoke Library pin) -> fixed 7eb723b, focused re-run 1 passed; browser sweep 320/390/430/768/1024/1440 light+dark+forced-colors, no h-overflow; lock parity restored first (playwright 1.62.1, node 24.19.0) | | 2026-08-04 | codex/fix-mode-switching-and-loading-issues | 3e3b224a2ec13928d1e28173b1fc4c75d202d7d2 | PR #1607 unblock/fix | clean — behind 0, merge-tree clean, 0 unresolved threads, required CI in progress (no code fix) | merge-tree clean; behind_by 0; Unit/Build/Static/ProdUI in progress; no failing required | | 2026-08-04 | codex/v2-design-system-phase1-accessibility | 7e19964973f38c769ca725d6d53aff088ed182b3 | V2 Phase 1 Lane B accessibility tables announcements document preview | approved after rapid retry announcement identity fix | focused Vitest 35p + follow-up 15p; typecheck PASS; independent review clean | @@ -702,3 +701,4 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie | 2026-08-07 | claude/pr-handoff-loop-prevention-54y5zr (PR #1670) | dfe2946110e0ff93bd4acc571ae79c26b79a7a85 | PR #1670 heavy review-and-fix | synced origin/main (behind-but-clean DIRTY cleared); fixed CodeRabbit checks-cell to name exact #1649 gates + incomplete verify:pr-local/ui + no provider checks; Bugbot none; no P0/P1; #258/#ledger delta accurate; merge-tree clean; threads cleared | verify:cheap 519 files/5493 passed; verify:pr-local docs scope (format+docs+ledger+outstanding-issues); check:branch-review-ledger; check:outstanding-issues; no provider gates | | 2026-08-07 | claude/handover-review-nlhuln | 978623337c12dc1721fe5236eadbf9a5ad929f03 | mode nav remaining modes: factsheets adoption (PR #1674) | Adopted the shared ModeNav for factsheets (Topics + Search); replaced the action-only entry, added the activeId branch, q/category/run carry, BookOpenText icon; three pinned adopted-mode lists updated together; record-route protection pinned at render now the item-count protection has expired | lint clean; typecheck clean; test 518/519 files (pr-handoff-stop failure confirmed pre-existing via stashed re-run); focused 5 files 95 tests; ui-mode-nav-density 55 passed incl 7 new factsheets rows; two mutation checks confirmed red; format committed; verify:pr-local blocked at check:installed-lock-parity (playwright 1.62.0 vs 1.62.1) | | 2026-08-07 | claude/handover-review-nlhuln | 4ff613c10fbf734b1e740a31611296c17c791ec7 | mode nav remaining modes: vestigial strip removal (PR #1679) | Removed the single-button action strip from answer/documents/services/forms/favourites/prescribing/tools; deleted the registry index-0 fallback (TS2493-forced) and the dead documents clause; stripped modeItems/onSearch/modeAriaLabel/stickyTop from PageSecondaryNavigation, keeping the empty-registry return below the information-section branch; kept the action kind with a no-live-consumer note. Completes the 13-mode navigation rollout. | lint exit 0; typecheck clean; focused 5 files 97 tests; test 518/519 files (pr-handoff-stop re-confirmed pre-existing on this base via stashed re-run); ui-mode-nav-density + ui-accessibility 71 passed (landmark scan green); branch-order guard mutation-checked (hoisting it fails 2 tests); format committed; verify:pr-local blocked at check:installed-lock-parity (playwright 1.62.0 vs 1.62.1) | +| 2026-08-05 | HEAD | 2a8881afad230880166de60a533e17588d9920ec | seven-report repo-wide audit | P2 confirmed: live drift and live-only migration; mobile CLS; ACL runner; OOXML declared-size robustness; assertion false positives. Numerous report claims stale, narrowed, or unsafe. | verify:cheap (5088 pass, 3 skip, 1 timeout); focused retry 21/21 pass; build pass; bundle budget pass; offline RAG 574/574; assertions 98%; live drift 34; browser CLS 0.228/0.218 | From 04d169712aec3e38bf80676dd9ea5a6f8ed48d9e Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 7 Aug 2026 12:18:20 +0000 Subject: [PATCH 3/3] docs(ledger): record PR #1683 review-and-fix Append the babysit review row for the post-sync consolidated tip. Co-authored-by: BigSimmo --- docs/branch-review-ledger.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/branch-review-ledger.md b/docs/branch-review-ledger.md index 6af7a9c742..ba3ab2ccfd 100644 --- a/docs/branch-review-ledger.md +++ b/docs/branch-review-ledger.md @@ -702,3 +702,4 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie | 2026-08-07 | claude/handover-review-nlhuln | 978623337c12dc1721fe5236eadbf9a5ad929f03 | mode nav remaining modes: factsheets adoption (PR #1674) | Adopted the shared ModeNav for factsheets (Topics + Search); replaced the action-only entry, added the activeId branch, q/category/run carry, BookOpenText icon; three pinned adopted-mode lists updated together; record-route protection pinned at render now the item-count protection has expired | lint clean; typecheck clean; test 518/519 files (pr-handoff-stop failure confirmed pre-existing via stashed re-run); focused 5 files 95 tests; ui-mode-nav-density 55 passed incl 7 new factsheets rows; two mutation checks confirmed red; format committed; verify:pr-local blocked at check:installed-lock-parity (playwright 1.62.0 vs 1.62.1) | | 2026-08-07 | claude/handover-review-nlhuln | 4ff613c10fbf734b1e740a31611296c17c791ec7 | mode nav remaining modes: vestigial strip removal (PR #1679) | Removed the single-button action strip from answer/documents/services/forms/favourites/prescribing/tools; deleted the registry index-0 fallback (TS2493-forced) and the dead documents clause; stripped modeItems/onSearch/modeAriaLabel/stickyTop from PageSecondaryNavigation, keeping the empty-registry return below the information-section branch; kept the action kind with a no-live-consumer note. Completes the 13-mode navigation rollout. | lint exit 0; typecheck clean; focused 5 files 97 tests; test 518/519 files (pr-handoff-stop re-confirmed pre-existing on this base via stashed re-run); ui-mode-nav-density + ui-accessibility 71 passed (landmark scan green); branch-order guard mutation-checked (hoisting it fails 2 tests); format committed; verify:pr-local blocked at check:installed-lock-parity (playwright 1.62.0 vs 1.62.1) | | 2026-08-05 | HEAD | 2a8881afad230880166de60a533e17588d9920ec | seven-report repo-wide audit | P2 confirmed: live drift and live-only migration; mobile CLS; ACL runner; OOXML declared-size robustness; assertion false positives. Numerous report claims stale, narrowed, or unsafe. | verify:cheap (5088 pass, 3 skip, 1 timeout); focused retry 21/21 pass; build pass; bundle budget pass; offline RAG 574/574; assertions 98%; live drift 34; browser CLS 0.228/0.218 | +| 2026-08-07 | codex/consolidated-ledger-updates (PR #1683) | 413e679bb92cb19717d6d8301764df44694eb73e | review-and-fix PR #1683 | synced origin/main (behind-but-clean DIRTY cleared); restored main ledger order + sole seven-report row; Bugbot none; no P0/P1; merge-tree clean | verify:pr-local docs scope PASS (format:changed Prettier; check:branch-review-ledger 648; docs links 1650; outstanding-issues 258); merge-tree clean |