fix(update): skip setting defaults for single embedded subdocs underneath maps

vkarpov15 · vkarpov15 · commit 0314b02ca5ef · 2019-06-22T14:29:02.000-07:00
Fix #7909
diff --git a/lib/helpers/setDefaultsOnInsert.js b/lib/helpers/setDefaultsOnInsert.js
@@ -69,7 +69,8 @@ module.exports = function(filter, schema, castedDoc, options) {
   }
 
   schema.eachPath(function(path, schemaType) {
-    if (schemaType.$isSingleNested) {
+    // Skip single nested paths if underneath a map
+    if (schemaType.$isSingleNested && !schemaType.path.endsWith('.$*')) {
       // Only handle nested schemas 1-level deep to avoid infinite
       // recursion re: https://github.com/mongodb-js/mongoose-autopopulate/issues/11
       schemaType.schema.eachPath(function(_path, _schemaType) {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,8 @@ module.exports = function(filter, schema, castedDoc, options) {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`schema.eachPath(function(path, schemaType) {`
`72`		`- if (schemaType.$isSingleNested) {`
	`72`	`+ // Skip single nested paths if underneath a map`
	`73`	`+ if (schemaType.$isSingleNested && !schemaType.path.endsWith('.$*')) {`
`73`	`74`	`// Only handle nested schemas 1-level deep to avoid infinite`
`74`	`75`	`// recursion re: https://github.com/mongodb-js/mongoose-autopopulate/issues/11`
`75`	`76`	`schemaType.schema.eachPath(function(_path, _schemaType) {`