fix(desktop): correct the updater capability URL pattern#59
Merged
Conversation
The remote.urls pattern (http://localhost:34115 and /*) didn't match the webview's
actual URL, so the IPC bridge (__TAURI_INTERNALS__) never initialized — isTauri()
stayed false and the updater silently never invoked. Use the documented
http://localhost:*/** (port wildcard + recursive path), which matches. Verified in a
debug run: updater_check now fires ("querying" → "up to date").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
remote.urlsgrant usedhttp://localhost:34115/http://localhost:34115/*, which does not match the webview URL — so__TAURI_INTERNALS__never initialized,isTauri()was false, andupdater_checkwas never invoked (silently). Nothing showed.Fix: use the documented pattern
http://localhost:*/**(port wildcard + recursive path).Verified locally in a
tauri devrun — the Rust log now showsupdater_check: querying for updates→up to date, i.e. the IPC command fires. (Also flushed out two confounders during debugging: an old single-instance window blocking new launches, and a stale.outputbundle.)