Skip to content

Commit 8ff3fef

Browse files
committed
use primary constructors for inner test sub-classes
1 parent efc5637 commit 8ff3fef

24 files changed

+167
-1168
lines changed

test/Remote.Linq.Async.Queryable.Tests/When_querying_async.cs

Lines changed: 6 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -11,65 +11,31 @@ namespace Remote.Linq.Async.Queryable.Tests;
1111

1212
public abstract class When_querying_async
1313
{
14-
public class With_stream_provider_and_data_provider : When_querying_async
15-
{
16-
public With_stream_provider_and_data_provider(bool useDynamicObjectConversion = false)
17-
: base(useDynamicObjectConversion: useDynamicObjectConversion)
18-
{
19-
}
20-
}
14+
public class With_stream_provider_and_data_provider(bool useDynamicObjectConversion = false) : When_querying_async(useDynamicObjectConversion: useDynamicObjectConversion);
2115

22-
public class With_dynamic_object_stream_provider_and_data_provider : With_stream_provider_and_data_provider
23-
{
24-
public With_dynamic_object_stream_provider_and_data_provider()
25-
: base(useDynamicObjectConversion: true)
26-
{
27-
}
28-
}
16+
public class With_dynamic_object_stream_provider_and_data_provider() : With_stream_provider_and_data_provider(useDynamicObjectConversion: true);
2917

30-
public class With_stream_provider_only : When_querying_async, IDisposable
18+
public class With_stream_provider_only(bool useDynamicObjectConversion = false) : When_querying_async(createAsyncDataProvider: false, useDynamicObjectConversion: useDynamicObjectConversion), IDisposable
3119
{
32-
public With_stream_provider_only(bool useDynamicObjectConversion = false)
33-
: base(createAsyncDataProvider: false, useDynamicObjectConversion: useDynamicObjectConversion)
34-
{
35-
}
36-
3720
public void Dispose()
3821
{
3922
AsyncDataProviderInvocationCount.ShouldBe(0);
4023
AsyncStreamProviderInvocationCount.ShouldBe(1);
4124
}
4225
}
4326

44-
public class With_dynamic_object_stream_provider_only : With_stream_provider_only
45-
{
46-
public With_dynamic_object_stream_provider_only()
47-
: base(useDynamicObjectConversion: true)
48-
{
49-
}
50-
}
27+
public class With_dynamic_object_stream_provider_only() : With_stream_provider_only(useDynamicObjectConversion: true);
5128

52-
public class With_async_data_provider_only : When_querying_async, IDisposable
29+
public class With_async_data_provider_only(bool useDynamicObjectConversion = false) : When_querying_async(createAsyncStreamProvider: false, useDynamicObjectConversion: useDynamicObjectConversion), IDisposable
5330
{
54-
public With_async_data_provider_only(bool useDynamicObjectConversion = false)
55-
: base(createAsyncStreamProvider: false, useDynamicObjectConversion: useDynamicObjectConversion)
56-
{
57-
}
58-
5931
public void Dispose()
6032
{
6133
AsyncStreamProviderInvocationCount.ShouldBe(0);
6234
AsyncDataProviderInvocationCount.ShouldBe(1);
6335
}
6436
}
6537

66-
public class With_async_dynamic_object_data_provider_only : With_async_data_provider_only
67-
{
68-
public With_async_dynamic_object_data_provider_only()
69-
: base(useDynamicObjectConversion: true)
70-
{
71-
}
72-
}
38+
public class With_async_dynamic_object_data_provider_only() : With_async_data_provider_only(useDynamicObjectConversion: true);
7339

7440
private readonly bool _hasStreamProviderSupport;
7541
private readonly bool _hasDataProviderSupport;

test/Remote.Linq.Tests/RemoteQueryable/When_running_query.cs

Lines changed: 8 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -23,72 +23,24 @@ namespace Remote.Linq.Tests.RemoteQueryable;
2323

2424
public abstract class When_running_query
2525
{
26-
public class With_no_serialization : When_running_query
27-
{
28-
public With_no_serialization()
29-
: base(x => x)
30-
{
31-
}
32-
}
26+
public class With_no_serialization() : When_running_query(x => x);
3327

34-
public class With_data_contract_serializer : When_running_query
35-
{
36-
public With_data_contract_serializer()
37-
: base(DataContractSerializationHelper.Clone)
38-
{
39-
}
40-
}
28+
public class With_data_contract_serializer() : When_running_query(DataContractSerializationHelper.Clone);
4129

42-
public class With_newtonsoft_json_serializer : When_running_query
43-
{
44-
public With_newtonsoft_json_serializer()
45-
: base(x => (Expression)NewtonsoftJsonSerializationHelper.Clone(x, x.GetType()))
46-
{
47-
}
48-
}
30+
public class With_newtonsoft_json_serializer() : When_running_query(x => (Expression)NewtonsoftJsonSerializationHelper.Clone(x, x.GetType()));
4931

50-
public class With_system_text_json_serializer : When_running_query
51-
{
52-
public With_system_text_json_serializer()
53-
: base(x => (Expression)SystemTextJsonSerializationHelper.Clone(x, x.GetType()))
54-
{
55-
}
56-
}
32+
public class With_system_text_json_serializer() : When_running_query(x => (Expression)SystemTextJsonSerializationHelper.Clone(x, x.GetType()));
5733

58-
public class With_xml_serializer : When_running_query
59-
{
60-
public With_xml_serializer()
61-
: base(XmlSerializationHelper.Clone)
62-
{
63-
}
64-
}
34+
public class With_xml_serializer() : When_running_query(XmlSerializationHelper.Clone);
6535

6636
#if !NET8_0_OR_GREATER
67-
public class With_binary_formatter : When_running_query
68-
{
69-
public With_binary_formatter()
70-
: base(BinarySerializationHelper.Clone)
71-
{
72-
}
73-
}
37+
public class With_binary_formatter() : When_running_query(BinarySerializationHelper.Clone);
7438
#endif // NET8_0_OR_GREATER
7539

76-
public class With_protobuf_net_serializer : When_running_query
77-
{
78-
public With_protobuf_net_serializer()
79-
: base(ProtobufNetSerializationHelper.Clone)
80-
{
81-
}
82-
}
40+
public class With_protobuf_net_serializer() : When_running_query(ProtobufNetSerializationHelper.Clone);
8341

8442
#if NETFRAMEWORK
85-
public class With_net_data_contract_serializer : When_running_query
86-
{
87-
public With_net_data_contract_serializer()
88-
: base(NetDataContractSerializationHelper.Clone)
89-
{
90-
}
91-
}
43+
public class With_net_data_contract_serializer() : When_running_query(NetDataContractSerializationHelper.Clone);
9244
#endif // NETFRAMEWORK
9345

9446
private readonly IQueryable<Category> _categoryQueryable;

test/Remote.Linq.Tests/Serialization/Expressions/When_subquery_expression_use_same_parameter_name.cs

Lines changed: 7 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -15,64 +15,22 @@ namespace Remote.Linq.Tests.Serialization.Expressions;
1515
public abstract class When_subquery_expression_use_same_parameter_name
1616
{
1717
#if !NET8_0_OR_GREATER
18-
public class With_binary_formatter : When_subquery_expression_use_same_parameter_name
19-
{
20-
public With_binary_formatter()
21-
: base(BinarySerializationHelper.Clone)
22-
{
23-
}
24-
}
18+
public class With_binary_formatter() : When_subquery_expression_use_same_parameter_name(BinarySerializationHelper.Clone);
2519
#endif // NET8_0_OR_GREATER
2620

27-
public class With_data_contract_serializer : When_subquery_expression_use_same_parameter_name
28-
{
29-
public With_data_contract_serializer()
30-
: base(DataContractSerializationHelper.Clone)
31-
{
32-
}
33-
}
21+
public class With_data_contract_serializer() : When_subquery_expression_use_same_parameter_name(DataContractSerializationHelper.Clone);
3422

35-
public class With_newtonsoft_json_serializer : When_subquery_expression_use_same_parameter_name
36-
{
37-
public With_newtonsoft_json_serializer()
38-
: base(x => (Expression)NewtonsoftJsonSerializationHelper.Clone(x, x.GetType()))
39-
{
40-
}
41-
}
23+
public class With_newtonsoft_json_serializer() : When_subquery_expression_use_same_parameter_name(x => (Expression)NewtonsoftJsonSerializationHelper.Clone(x, x.GetType()));
4224

43-
public class With_system_text_json_serializer : When_subquery_expression_use_same_parameter_name
44-
{
45-
public With_system_text_json_serializer()
46-
: base(x => (Expression)SystemTextJsonSerializationHelper.Clone(x, x.GetType()))
47-
{
48-
}
49-
}
25+
public class With_system_text_json_serializer() : When_subquery_expression_use_same_parameter_name(x => (Expression)SystemTextJsonSerializationHelper.Clone(x, x.GetType()));
5026

5127
#if NETFRAMEWORK
52-
public class With_net_data_contract_serializer : When_subquery_expression_use_same_parameter_name
53-
{
54-
public With_net_data_contract_serializer()
55-
: base(NetDataContractSerializationHelper.Clone)
56-
{
57-
}
58-
}
28+
public class With_net_data_contract_serializer() : When_subquery_expression_use_same_parameter_name(NetDataContractSerializationHelper.Clone);
5929
#endif // NETFRAMEWORK
6030

61-
public class With_protobuf_net_serializer : When_using_LoopExpressions
62-
{
63-
public With_protobuf_net_serializer()
64-
: base(ProtobufNetSerializationHelper.Clone)
65-
{
66-
}
67-
}
31+
public class With_protobuf_net_serializer() : When_using_LoopExpressions(ProtobufNetSerializationHelper.Clone);
6832

69-
public class With_xml_serializer : When_subquery_expression_use_same_parameter_name
70-
{
71-
public With_xml_serializer()
72-
: base(XmlSerializationHelper.Clone)
73-
{
74-
}
75-
}
33+
public class With_xml_serializer() : When_subquery_expression_use_same_parameter_name(XmlSerializationHelper.Clone);
7634

7735
private interface IValue
7836
{

test/Remote.Linq.Tests/Serialization/Expressions/When_using_BlockExpression.cs

Lines changed: 7 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -11,64 +11,22 @@ namespace Remote.Linq.Tests.Serialization.Expressions;
1111
public abstract class When_using_BlockExpression
1212
{
1313
#if !NET8_0_OR_GREATER
14-
public class With_binary_formatter : When_using_BlockExpression
15-
{
16-
public With_binary_formatter()
17-
: base(BinarySerializationHelper.Clone)
18-
{
19-
}
20-
}
14+
public class With_binary_formatter() : When_using_BlockExpression(BinarySerializationHelper.Clone);
2115
#endif // NET8_0_OR_GREATER
2216

23-
public class With_data_contract_serializer : When_using_BlockExpression
24-
{
25-
public With_data_contract_serializer()
26-
: base(DataContractSerializationHelper.CloneExpression)
27-
{
28-
}
29-
}
17+
public class With_data_contract_serializer() : When_using_BlockExpression(DataContractSerializationHelper.CloneExpression);
3018

31-
public class With_newtonsoft_json_serializer : When_using_BlockExpression
32-
{
33-
public With_newtonsoft_json_serializer()
34-
: base(NewtonsoftJsonSerializationHelper.Clone)
35-
{
36-
}
37-
}
19+
public class With_newtonsoft_json_serializer() : When_using_BlockExpression(NewtonsoftJsonSerializationHelper.Clone);
3820

39-
public class With_system_text_json_serializer : When_using_BlockExpression
40-
{
41-
public With_system_text_json_serializer()
42-
: base(SystemTextJsonSerializationHelper.Clone)
43-
{
44-
}
45-
}
21+
public class With_system_text_json_serializer() : When_using_BlockExpression(SystemTextJsonSerializationHelper.Clone);
4622

4723
#if NETFRAMEWORK
48-
public class With_net_data_contract_serializer : When_using_BlockExpression
49-
{
50-
public With_net_data_contract_serializer()
51-
: base(NetDataContractSerializationHelper.Clone)
52-
{
53-
}
54-
}
24+
public class With_net_data_contract_serializer() : When_using_BlockExpression(NetDataContractSerializationHelper.Clone);
5525
#endif // NETFRAMEWORK
5626

57-
public class With_protobuf_net_serializer : When_using_BlockExpression
58-
{
59-
public With_protobuf_net_serializer()
60-
: base(ProtobufNetSerializationHelper.Clone)
61-
{
62-
}
63-
}
27+
public class With_protobuf_net_serializer() : When_using_BlockExpression(ProtobufNetSerializationHelper.Clone);
6428

65-
public class With_xml_serializer : When_using_BlockExpression
66-
{
67-
public With_xml_serializer()
68-
: base(XmlSerializationHelper.CloneExpression)
69-
{
70-
}
71-
}
29+
public class With_xml_serializer() : When_using_BlockExpression(XmlSerializationHelper.CloneExpression);
7230

7331
private readonly Expression<Func<decimal, string>> _originalExpression;
7432

test/Remote.Linq.Tests/Serialization/Expressions/When_using_ConstExpression_of_expression.cs

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -15,47 +15,17 @@ namespace Remote.Linq.Tests.Serialization.Expressions;
1515
public abstract class When_using_ConstExpression_of_expression
1616
{
1717
#if !NET8_0_OR_GREATER
18-
public class With_binary_formatter : When_using_ConstExpression_of_expression
19-
{
20-
public With_binary_formatter()
21-
: base(BinarySerializationHelper.Clone)
22-
{
23-
}
24-
}
18+
public class With_binary_formatter() : When_using_ConstExpression_of_expression(BinarySerializationHelper.Clone);
2519
#endif // NET8_0_OR_GREATER
2620

27-
public class With_data_contract_serializer : When_using_ConstExpression_of_expression
28-
{
29-
public With_data_contract_serializer()
30-
: base(DataContractSerializationHelper.CloneExpression)
31-
{
32-
}
33-
}
21+
public class With_data_contract_serializer() : When_using_ConstExpression_of_expression(DataContractSerializationHelper.CloneExpression);
3422

35-
public class With_newtonsoft_json_serializer : When_using_ConstExpression_of_expression
36-
{
37-
public With_newtonsoft_json_serializer()
38-
: base(NewtonsoftJsonSerializationHelper.Clone)
39-
{
40-
}
41-
}
23+
public class With_newtonsoft_json_serializer() : When_using_ConstExpression_of_expression(NewtonsoftJsonSerializationHelper.Clone);
4224

43-
public class With_system_text_json_serializer : When_using_ConstExpression_of_expression
44-
{
45-
public With_system_text_json_serializer()
46-
: base(SystemTextJsonSerializationHelper.Clone)
47-
{
48-
}
49-
}
25+
public class With_system_text_json_serializer() : When_using_ConstExpression_of_expression(SystemTextJsonSerializationHelper.Clone);
5026

5127
#if NETFRAMEWORK
52-
public class With_net_data_contract_serializer : When_using_ConstExpression_of_expression
53-
{
54-
public With_net_data_contract_serializer()
55-
: base(NetDataContractSerializationHelper.Clone)
56-
{
57-
}
58-
}
28+
public class With_net_data_contract_serializer() : When_using_ConstExpression_of_expression(NetDataContractSerializationHelper.Clone);
5929
#endif // NETFRAMEWORK
6030

6131
private readonly Func<RemoteExpression, RemoteExpression> _serialize;

0 commit comments

Comments
 (0)