ComfyUI.cpp inside the engine: 1bit comfy

[bong-water-water-bong]

Brings ComfyUI.cpp into the engine.

• Pinned: submodule third_party/comfyui.cpp at 4a08238 (1bit-MONSTER/comfyui.cpp master, with the SD1.5 fixes and the ComfyUI pin).
• Build: -DONEBIT_COMFYUI=ON runs scripts/build-comfyui.sh, which builds build/comfyui/comfyui_cpp against LibTorch from Python's torch. It's off by default, and CI doesn't check out submodules, so CI is unaffected.
• Run: 1bit comfy <workflow.json> runs a ComfyUI API-format workflow. It looks for the binary in $ONEBIT_COMFYUI first, then this build's, then PATH.
• License: ComfyUI.cpp is GPL-3.0 and the engine is Apache-2.0. The engine runs ComfyUI.cpp as a separate program and never links it, the same way it treats the Linux kernel. NOTICE says so.

Measured on strixhalo (separate build of this branch, v1-5-pruned-emaonly): 1bit comfy runs txt2img "a cat" (seed 0, 20 steps, 512×512) in 48 s on the CPU, at 50.6 dB PSNR against Python ComfyUI (pinned 1568e6c). Image-to-image: 51.2 dB.

Docs: docs/comfyui.md (also in the site sidebar under Components), README feature list, NOTICE.

🤖 Generated with Claude Code

[context7]

Docs7 for 1bit-monster/engine

Result	Status	Action
Deployment	➖ Not used	—
Content review	➖ Did not run. This site has no agent runs available this month. Wait for the monthly reset or check your Docs7 plan.	—

Commit 0f8f705

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential Security Risk in `run_comfy` The run_comfy function in app/main.cpp uses execvp to execute the ComfyUI binary. If the ONEBIT_COMFYUI environment variable is set to a path pointing to a malicious binary, or if the binary is replaced between the check for existence and the execution, it could lead to arbitrary code execution. This is a security concern as it allows for potential privilege escalation or code injection if the environment is not properly controlled. int run_comfy(int argc, char** argv) { if (argc < 1 || !std::strcmp(argv[0], "-h") || !std::strcmp(argv[0], "--help")) { std::printf("usage: 1bit comfy <workflow.json>\n" " runs a ComfyUI API-format workflow (SD1.5 txt2img/img2img, see docs/comfyui.md)\n"); return argc < 1 ? 2 : 0; } std::string bin; if (const char* e = std::getenv("ONEBIT_COMFYUI"); e && *e) bin = e; #ifdef ONEBIT_COMFYUI_BIN if (bin.empty() && std::filesystem::exists(ONEBIT_COMFYUI_BIN)) bin = ONEBIT_COMFYUI_BIN; #endif if (bin.empty()) bin = "comfyui_cpp"; std::vector<char*> args{bin.data()}; for (int i = 0; i < argc; ++i) args.push_back(argv[i]); args.push_back(nullptr); ::execvp(args[0], args.data()); std::fprintf(stderr, "1bit comfy: cannot run %s: %s (build with -DONEBIT_COMFYUI=ON or set ONEBIT_COMFYUI)\n", bin.c_str(), std::strerror(errno)); return 127; } Submodule Initialization Requirement The build-comfyui.sh script requires the third_party/comfyui.cpp submodule to be initialized. If this submodule is not initialized, the script will fail with an error message. This could be a problem for users who are not familiar with Git submodules or who do not have the submodule initialized, leading to build failures. [ -f "$src/CMakeLists.txt" ] || { echo "third_party/comfyui.cpp is empty: git submodule update --init third_party/comfyui.cpp"; exit 1; }