This repository was archived by the owner on Apr 16, 2019. It is now read-only.
convert $().data('someKey') to a json object if possible.#514
Merged
imaffett merged 1 commit intointel:masterfrom Dec 16, 2013
Merged
convert $().data('someKey') to a json object if possible.#514imaffett merged 1 commit intointel:masterfrom
imaffett merged 1 commit intointel:masterfrom
Conversation
the `data()` api is now using `attr()` internally, without any convertion, so it would be better to convert result to a json object if it is a legal json string.
imaffett
pushed a commit
that referenced
this pull request
Dec 16, 2013
convert $().data('someKey') to a json object if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: it might not be a bug, just make some improvement for
data()improvement description
now, the
data()is usingattr()internally which has no process to convert the result, even if the result is a json-like string.how to reproduce?
html
js
how to do?
try to convert the result to a json object if possible, otherwise return the original result.